Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/igmpproxy: Add igmpproxy module to nixos. #111506

Merged
merged 0 commits into from Dec 10, 2021
Merged

nixos/igmpproxy: Add igmpproxy module to nixos. #111506

merged 0 commits into from Dec 10, 2021

Conversation

sdier
Copy link
Contributor

@sdier sdier commented Jan 31, 2021

Motivation for this change

Add a module for igmpproxy to nixos.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sdier
Copy link
Contributor Author

sdier commented Jan 31, 2021

I realized through some more testing this evening that at boot this doesn't start properly, even with network-online.target ... will debug further.

@SuperSandro2000
Copy link
Member

I realized through some more testing this evening that at boot this doesn't start properly, even with network-online.target ... will debug further.

I'll mark it as draft until you could solve this. Feel free to undraft at any time.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft February 1, 2021 00:03
@sdier sdier force-pushed the igmpproxy-module branch 4 times, most recently from 6021b1c to a5a70e8 Compare February 1, 2021 00:43
@sdier
Copy link
Contributor Author

sdier commented Feb 1, 2021

Added documentation in the enable command for the issue I was running into.

@sdier sdier marked this pull request as ready for review February 1, 2021 00:44
@sdier sdier requested a review from Emantor May 8, 2021 23:34
@stale
Copy link

stale bot commented Nov 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2021
@sdier sdier closed this Dec 10, 2021
@ryantm ryantm merged commit 3a9d159 into NixOS:master Dec 10, 2021
@aanderse
Copy link
Member

@ryantm what happened here? "Files changed" shows as 0 for me ... 🤔

@sdier
Copy link
Contributor Author

sdier commented Dec 10, 2021

I was trying to clean up this branch on my side (some extra thing crept in) and it obviously confused github. :(

@ryantm
Copy link
Member

ryantm commented Dec 11, 2021

@aanderse I don't remember merging this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@Emantor Emantor Awaiting requested review from Emantor

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdier @SuperSandro2000 @aanderse @ryantm