Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-cli: 0.6.12 -> 0.7.4 #111513

Merged
merged 2 commits into from Feb 1, 2021
Merged

signal-cli: 0.6.12 -> 0.7.4 #111513

merged 2 commits into from Feb 1, 2021

Conversation

devzero
Copy link
Contributor

@devzero devzero commented Feb 1, 2021

Motivation for this change

Update signal-cli to newest version

Things done

bumped version number and hash, changed all references for jre_headless to openjdk11_headless due to java class file requirement of Java 11 in this version. Messed up last submission.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ivan and erictapen February 1, 2021 00:27
@grahamc grahamc merged commit 5b896d3 into NixOS:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan Awaiting requested review from ivan

@erictapen erictapen Awaiting requested review from erictapen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devzero @grahamc