NativeIO: Block filenames longer that 100 characters #27731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2712793
branch
from
9252263
to
7823c4c
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2712793
branch
3 times, most recently
from
e837cd2
to
95b2e37
Compare
This fixes a bug where maximum filename length would be installation-path and host configuration dependent. The proposed limit is enough for existing partner and test cases. Depending on developer feedback we might provide a Javascript-based solution as shown in this document: https://docs.google.com/document/d/1gjnHg9b0vuTul54MHAzRFfQ6T1XKdayYoGKs6Td8yuQ/edit?ts=5fc7a3ee&pli=1 Bug: 914488 Change-Id: I0b21d2144aee69b6cb82338365a3d6d419e2ca04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2712793 Commit-Queue: Emanuel Krivoy <krivoy@google.com> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#857408}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2712793
branch
from
95b2e37
to
5bc5704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where maximum filename length would be
installation-path and host configuration dependent. The proposed limit
is enough for existing partner and test cases. Depending on developer
feedback we might provide a Javascript-based solution as shown in this
document:
https://docs.google.com/document/d/1gjnHg9b0vuTul54MHAzRFfQ6T1XKdayYoGKs6Td8yuQ/edit?ts=5fc7a3ee&pli=1
Bug: 914488
Change-Id: I0b21d2144aee69b6cb82338365a3d6d419e2ca04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2712793
Commit-Queue: Emanuel Krivoy <krivoy@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857408}