Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alsaLib: fix build under musl-libc #110413

Merged
merged 2 commits into from Jan 22, 2021
Merged

alsaLib: fix build under musl-libc #110413

merged 2 commits into from Jan 22, 2021

Conversation

pjjw
Copy link
Contributor

@pjjw pjjw commented Jan 21, 2021

Motivation for this change

Presently, alsaLib doesn't build under musl. Looks like this was an inadvertent breakage from upstream, so pulling the upstream commit in to build under musl. Alpine linux takes the same approach.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pjjw
Copy link
Contributor Author

pjjw commented Jan 21, 2021

@GrahamcOfBorg build pkgsMusl.alsaLib

@SuperSandro2000
Copy link
Member

/rebase-staging

@pjjw @github-actions
alsaLib: fix build under musl-libc
bbfacc6 
there's a commit in upstream master that fixes the build issue here.
this patch is also applied in alpine linux.
@github-actions github-actions bot changed the base branch from master to staging January 22, 2021 00:22
@FRidh FRidh merged commit e73020d into NixOS:staging Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjjw @SuperSandro2000 @FRidh