Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need canonical storage solution to ensure binary consistency #8

Open
litghost opened this issue Jan 21, 2021 · 2 comments
Open

Need canonical storage solution to ensure binary consistency #8

litghost opened this issue Jan 21, 2021 · 2 comments

Comments

@litghost
Copy link
Contributor

litghost commented Jan 21, 2021 •
edited

Currently there are two sources of instability in the FPGA interchange capnp files:

  • strList order is unstable
  • Inconsistent compression output

This issue is to track adding logic to remove instability in the FPGA interchange capnp files. The goal is that the same data if canonical will generate the same file.

The strList order can be fixed by sorting the strList and re-numbering the ids. The inconsistent compression output can be solved by ensuring that the compress level between tools is consistent, and using a compression library that generates stable results.
@mithro
Copy link
Contributor

mithro commented Jan 21, 2021

I don't think diffability is the major goal. More making sure that two files which have identical data contents will be identical.

IE If the diff tool returns that two files are identical, then the canonical storage version of the files should have identical checksums.

@litghost
Copy link
Contributor Author

I don't think diffability is the major goal. More making sure that two files which have identical data contents will be identical.

IE If the diff tool returns that two files are identical, then the canonical storage version of the files should have identical checksums.

Agreed, I'll update the description.

@litghost litghost changed the title Need canonical storage solution to ensure binary diffablity Need canonical storage solution to ensure binary consistency Jan 21, 2021
@litghost litghost added this to To Do in FPGA interchange bootstrapping via automation Feb 25, 2021
kowalewskijan pushed a commit to antmicro/python-fpga-interchange that referenced this issue Apr 26, 2021
@litghost
Merge pull request chipsalliance#8 from litghost/enable_out_of_source…
bce4220 
…_build

Enable out of source build directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mithro @litghost