Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.vim-hcl: init at 2020-09-07 #110390

Merged
merged 2 commits into from Jan 22, 2021

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Unfortunately it hasn't been updated in a while, but it mostly adds syntax support for hcl and should be mostly compatible with hcl2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech
Copy link
Contributor

iblech commented Jan 21, 2021

Thank you for your work! :-)

It's a little bit unfortunate that the upstream repos don't work with tags for the releases. That way it's not only slightly more effort for us to keep nixpkgs up to date, but also from a security perspective it's less clear that these are the actual blessed releases (instead of someone's pull request or not even that -- as I understand it, anyone can add arbitrary commits to GitHub repos (but cannot change what the "master" or "main" tag refers to)).

If you have the resources, filing upstream issues for this lack of tags might be worthwhile.

@jonringer
Copy link
Contributor Author

it's a little bit unfortunate that the upstream repos don't work with tags for the releases.

most vim plugins are rolling releases

@SuperSandro2000
Copy link
Member

It's a little bit unfortunate that the upstream repos don't work with tags for the releases.

That is a generally problem in the vim ecosystem and nothing nixpkgs can solve alone.

If you have the resources, filing upstream issues for this lack of tags might be worthwhile.

That would be about 687 vim plugins to create for. Plug does not even have support for git tags.

That way it's not only slightly more effort for us to keep nixpkgs up to date, but also from a security perspective it's less clear that these are the actual blessed releases

That is a general problem with GitHub. It might be worth it to look into ways to prevent those fetches completely in nixpkgs.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110390 run on x86_64-linux 1

9 packages built:
  • spacevim
  • vimPlugins.Coqtail
  • vimPlugins.chadtree
  • vimPlugins.far-vim
  • vimPlugins.lualine-nvim
  • vimPlugins.nvim-treesitter
  • vimPlugins.playground
  • vimPlugins.vim-hcl
  • vimPlugins.vim-snipmate

@SuperSandro2000 SuperSandro2000 merged commit 74a5242 into NixOS:master Jan 22, 2021
@jonringer jonringer deleted the hashi-vim-plugins branch January 22, 2021 03:41
@jonringer jonringer changed the title vimPlugins.vim-hcl: init at 2017-10-10 vimPlugins.vim-hcl: init at 2020-09-07 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants