Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310: 3.10.0a3 -> 3.10.0a4 #110445

Merged
merged 1 commit into from Jan 22, 2021
Merged

python310: 3.10.0a3 -> 3.10.0a4 #110445

merged 1 commit into from Jan 22, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 22, 2021 •
edited

Motivation for this change

hopefully it's able to build wheels now...

pypa/wheel#354 was closed, but we may need to update packaging and wheel for it to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/110445

1 package built:
python310

@jonringer jonringer requested a review from FRidh as a code owner January 22, 2021 08:05
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110445 run on x86_64-linux 1

1 package built:
  • python310

@jonringer jonringer merged commit 0389d5b into NixOS:master Jan 22, 2021
@jonringer jonringer deleted the bump-python310a4 branch January 22, 2021 15:27
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 22, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110445 run on x86_64-darwin 1

1 package failed to build and already failed to build on hydra master:

:/

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/01h4dkp0nyrsw0zawmasxawhfik474ma-Python-3.10.0a4.tar.xz
source root is Python-3.10.0a4
setting SOURCE_DATE_EPOCH to timestamp 1609781164 of file Python-3.10.0a4/Misc/NEWS
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
applying patch /nix/store/345r2zz7pgiyk91j89qlf7mhs95jrv6f-no-ldconfig.patch
patching file Lib/ctypes/util.py
applying patch /nix/store/9kwzs3pplms8sijf55sdryypzvic4x1s-python-3.x-distutils-C++.patch
patching file Lib/_osx_support.py
patching file Lib/distutils/cygwinccompiler.py
Hunk #1 succeeded at 123 (offset -2 lines).
Hunk #2 succeeded at 140 (offset -2 lines).
Hunk #3 succeeded at 170 (offset -2 lines).
Hunk #4 succeeded at 310 (offset -2 lines).
patching file Lib/distutils/sysconfig.py
Hunk #1 FAILED at 170.
Hunk #2 FAILED at 187.
Hunk #3 succeeded at 231 (offset 23 lines).
2 out of 3 hunks FAILED -- saving rejects to file Lib/distutils/sysconfig.py.rej
patching file Lib/distutils/unixccompiler.py
Hunk #3 FAILED at 183.
1 out of 3 hunks FAILED -- saving rejects to file Lib/distutils/unixccompiler.py.rej
patching file Makefile.pre.in
Hunk #1 succeeded at 617 (offset 33 lines).

@jonringer
Copy link
Contributor Author

hmm, I don't have a darwin machine to verify that it works, and this is still an "alpha" build.

@jonringer
Copy link
Contributor Author

python310 wont be a stable release for at least another few months. So we still have time for darwin to "brought up to quality" before exposing the package set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SuperSandro2000