Skip to content

nixos/bacula: adding types to all options #110444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

nixos/bacula: adding types to all options #110444

merged 1 commit into from
Jan 25, 2021
+20 −0

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

fixes in the list of #76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Scriptkiddi Scriptkiddi marked this pull request as draft January 22, 2021 07:42
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 22, 2021
@Scriptkiddi Scriptkiddi marked this pull request as ready for review January 22, 2021 14:13
@Scriptkiddi Scriptkiddi changed the title bacula: adding types to all options WIP bacula: adding types to all options Jan 22, 2021
@SuperSandro2000
Copy link
Member

@Scriptkiddi please fix the eval error.

@Scriptkiddi Scriptkiddi force-pushed the bacula_types branch 8 times, most recently from 1e59252 to 5c2af97 Compare January 24, 2021 11:34
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2021
@Scriptkiddi Scriptkiddi changed the title WIP bacula: adding types to all options nixos/bacula: adding types to all options Jan 24, 2021
@Scriptkiddi
Copy link
Contributor Author

@SuperSandro2000 done

@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2021
@SuperSandro2000
Copy link
Member

@Scriptkiddi please fix the merge conflict.

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 24, 2021
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 25, 2021
@SuperSandro2000
Copy link
Member

Please do not merge master into a PR to solve a merge conflict. It is always required to use git rebase or otherwise the git history will be very confusing.

@Scriptkiddi
bacula: add types

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger
GPG key ID: 9424360B4B85C9E7
Verified
Learn about vigilant mode
41f4784
@Scriptkiddi
Copy link
Contributor Author

@SuperSandro2000 forgot that github does that its fixed now

@SuperSandro2000 SuperSandro2000 merged commit 896a342 into NixOS:master Jan 25, 2021
@Scriptkiddi Scriptkiddi deleted the bacula_types branch January 26, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scriptkiddi @SuperSandro2000