Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running compression detach tests on workers #27279

Merged
merged 1 commit into from Jan 22, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 22, 2021

compression-with-detach.tentative.any.js and
decompression-with-detach.tentative.any.js wpts use a postMessage() API
which only works in a window context to detach an ArrayBuffer. The call
does nothing in workers, so the tests trivially pass and there's no
point in running them.

Rename the tests so they only run in window context.

Change-Id: I31b6524b2c052302bfe1c4c53024e4dcaa5fc70d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643677
Commit-Queue: Adam Rice <ricea@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Auto-Submit: Adam Rice <ricea@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845865}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

compression-with-detach.tentative.any.js and
decompression-with-detach.tentative.any.js wpts use a postMessage() API
which only works in a window context to detach an ArrayBuffer. The call
does nothing in workers, so the tests trivially pass and there's no
point in running them.

Rename the tests so they only run in window context.

Change-Id: I31b6524b2c052302bfe1c4c53024e4dcaa5fc70d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643677
Commit-Queue: Adam Rice <ricea@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Auto-Submit: Adam Rice <ricea@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845865}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants