Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.corn: 8.8.1 → 8.12.0 #110366

Merged
merged 1 commit into from Jan 28, 2021
Merged

coqPackages.corn: 8.8.1 → 8.12.0 #110366

merged 1 commit into from Jan 28, 2021

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 21, 2021

Motivation for this change

Support for Coq 8.10–8.12.

Ping @Zimmi48

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Zimmi48
Zimmi48 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow missed that CoRN was packaged because nix-review didn't build it when run.

@vbgl
Copy link
Contributor Author

vbgl commented Jan 27, 2021

@GrahamcOfBorg build coqPackages.corn

@vbgl vbgl merged commit c174292 into NixOS:master Jan 28, 2021
@vbgl vbgl deleted the coq-corn-8.12 branch January 28, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Zimmi48