Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slurm: 20.11.2.1 -> 20.11.3.1 #110367

Merged
merged 2 commits into from Jan 21, 2021
Merged

slurm: 20.11.2.1 -> 20.11.3.1 #110367

merged 2 commits into from Jan 21, 2021

Conversation

markuskowa
Copy link
Member

Motivation for this change

Bugfix update: https://github.com/SchedMD/slurm/blob/slurm-20.11/NEWS

Things done
  • update
  • fixed test to remove deprecated option
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jagajaga January 21, 2021 17:30
@SuperSandro2000 SuperSandro2000 changed the title Upd slurm slurm: 20.11.2.1 -> 20.11.3.1 Jan 21, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 110367 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • python37Packages.pyslurm
  • python38Packages.pyslurm
  • python39Packages.pyslurm

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110367 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python37Packages.pyslurm
  • python38Packages.pyslurm
  • python39Packages.pyslurm
2 packages built:
  • slurm
  • slurm-spank-x11

@markuskowa markuskowa merged commit afa23b8 into NixOS:master Jan 21, 2021
@markuskowa markuskowa deleted the upd-slurm branch January 21, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @SuperSandro2000