Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/usbguard: init #110389

Merged
merged 1 commit into from Jan 23, 2021
Merged

nixos/tests/usbguard: init #110389

merged 1 commit into from Jan 23, 2021

Conversation

tnias
Copy link
Contributor

@tnias tnias commented Jan 21, 2021

Motivation for this change

The usbguard module had no tests before. And I like to have tests for stuff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech
Copy link
Contributor

iblech commented Jan 21, 2021

Awesome! I cannot test (lacking a functioning qemu), but LGTM!

@tnias tnias mentioned this pull request Jan 21, 2021
Merged
11 tasks
stigtsp
stigtsp requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via nix-build nixos/tests/usbguard.nix, looks good!

Could you add passthru.tests = nixosTests.usbguard; to pkgs/os-specific/linux/usbguard/default.nix as well?

@tnias
Copy link
Contributor Author

tnias commented Jan 22, 2021

Could you add passthru.tests = nixosTests.usbguard; to pkgs/os-specific/linux/usbguard/default.nix as well?

Added to the commit.

@tnias tnias requested a review from stigtsp January 22, 2021 20:59
@stigtsp
Copy link
Member

stigtsp commented Jan 23, 2021

@GrahamcOfBorg build usbguard.tests

stigtsp
stigtsp approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution!

@stigtsp stigtsp merged commit c52a11e into NixOS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tnias @iblech @stigtsp