Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freedroid: init at 1.2.1 #110433

Merged
merged 2 commits into from Jan 28, 2021
Merged

freedroid: init at 1.2.1 #110433

merged 2 commits into from Jan 28, 2021

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 22, 2021

Motivation for this change

Freedroid Classic is a clone of the classic Paradroid game with an awesome soundtrack. It is available on Debian and Arch. This pull request adds Freedroid Classic to nixpkgs (in a newer version than available in those distros).

This pull request consists of two commits. The second adds the game. The first exposes the optional dependency on libmikmod in SDL_mixer so that we can actually enjoy the soundtrack in the game.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech iblech changed the title Patch freedroid freedroid: init at 1.2.1 Jan 22, 2021
@siraben
Copy link
Member

siraben commented Jan 22, 2021

Result of nixpkgs-review pr 110433 run on x86_64-darwin 1

1 package built:
  • freedroid

@siraben
Copy link
Member

siraben commented Jan 22, 2021

Builds and launches on macOS, I hear the sound but does not render.

Screen Shot 2021-01-22 at 10 36 48

@iblech
Copy link
Contributor Author

iblech commented Jan 22, 2021

Thank you for the review, @siraben! Unfortunately I cannot debug this, lacking access to a darwin machine. Will mark it as broken on darwin.

SuperSandro2000
SuperSandro2000 requested changes Jan 22, 2021
View reviewed changes
pkgs/development/libraries/SDL_mixer/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/SDL_mixer/default.nix Outdated Show resolved Hide resolved
pkgs/games/freedroid/default.nix Outdated Show resolved Hide resolved
pkgs/games/freedroid/default.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Jan 22, 2021
View reviewed changes
pkgs/games/freedroid/default.nix Outdated Show resolved Hide resolved
@iblech iblech force-pushed the patch-freedroid branch 2 times, most recently from 4b10113 to 8d091dd Compare January 24, 2021 16:10
@ofborg ofborg bot requested a review from lovek323 January 27, 2021 18:23
@SuperSandro2000 SuperSandro2000 merged commit 8d2a780 into NixOS:master Jan 28, 2021
@iblech
Copy link
Contributor Author

iblech commented Jan 28, 2021

@SuperSandro2000, thank you very much for all your work with the pull requests! Very much appreciated. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@siraben siraben siraben approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iblech @siraben @SuperSandro2000