Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundix: add final newline patch, gemset*.nix: add final newline #110395

Merged
merged 3 commits into from Jan 22, 2021
Merged

bundix: add final newline patch, gemset*.nix: add final newline #110395

merged 3 commits into from Jan 22, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

@SuperSandro2000 SuperSandro2000 merged commit 9a92886 into NixOS:master Jan 22, 2021
@zowoq zowoq deleted the gemset branch January 22, 2021 11:09
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2021

I also merged the bundix pull request.

@fabaff fabaff mentioned this pull request Jan 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: ruby 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @Mic92 @SuperSandro2000