Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxxopts: init at 2.2.1 #110441

Merged
merged 2 commits into from Jan 31, 2021
Merged

cxxopts: init at 2.2.1 #110441

merged 2 commits into from Jan 31, 2021

Conversation

spease
Copy link
Contributor

@spease spease commented Jan 22, 2021

Motivation for this change

cxxopts: init at 2.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Running on an M1 mac, so I can't virtualize to test under Linux. However, it's a header-only C++ library, and I've enabled tests so hopefully OfBorg will pick up any issues. Packaging was pretty straightforward.

SuperSandro2000
SuperSandro2000 requested changes Jan 22, 2021
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/libraries/cxxopts/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/cxxopts/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/cxxopts/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110441 run on x86_64-darwin 1

1 package built:
  • cxxopts

@spease
Copy link
Contributor Author

spease commented Jan 25, 2021

I believe I've gotten all the review comments. Let me know if there's anything else.

SuperSandro2000
SuperSandro2000 requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable unicode help by default? Please squash the review commit into the package init commit.

pkgs/development/libraries/cxxopts/default.nix Show resolved Hide resolved
@spease
Copy link
Contributor Author

spease commented Jan 28, 2021

Done. Let me know if you need any more changes. This has been a great learning experience for me. I didn't realize GitHub dealt this well with rebasing.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110441 run on x86_64-darwin 1

1 package built:
  • cxxopts

SuperSandro2000
SuperSandro2000 requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the package init commit to cxxopts: init at 2.2.1 without the v.

@spease
Copy link
Contributor Author

spease commented Jan 30, 2021

Done

@SuperSandro2000 SuperSandro2000 merged commit 27df874 into NixOS:master Jan 31, 2021
@spease spease deleted the cxxopts branch January 31, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spease @SuperSandro2000