Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procmail: Drop the package #110384

Closed
wants to merge 1 commit into from
Closed

procmail: Drop the package #110384

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jan 21, 2021

Procmail has been unmaintained since 2001 (almost 20 years now), the last maintainer
advises use of another tool, and "a number of security vulnerabilities
have been discovered since its last release" (source is the english
Wikipedia).
The Wikipedia article also quotes https://lwn.net/Articles/416901/

Motivation for this change

Legacy software cleanup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
procmail: Drop the package
911dbf8 
Procmail has been unmaintained since 2001 (almost 20 years now), the last maintainer
advises use of another tool, and "a number of security vulnerabilities
have been discovered since its last release" (source is the english
Wikipedia).
The Wikipedia article also quotes https://lwn.net/Articles/416901/
@dasJ
Copy link
Member Author

dasJ commented Jan 21, 2021

I plan on adding a warning to release-20.09 once this is merged so people have time to switch to a more maintained tool.

@dasJ dasJ requested a review from ajs124 January 22, 2021 20:26
@ajs124 ajs124 removed their request for review January 22, 2021 23:40
symphorien
symphorien requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has known vulnerabilities, then it should be labeled as meta.knownVulnerabilities. This is not a reason to remove a package which is present on all major distros https://repology.org/project/procmail/versions . The comment in all-packages.nix expresses how procmail belongs to those superseded, but still traditional utils that should be kept as long as they compile.

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
@dasJ dasJ closed this Jul 26, 2021
@dasJ dasJ deleted the drop/procmail branch July 26, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @SuperSandro2000 @symphorien