Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-bindgen: Resolve "/usr/bin/env bash" to fix usage in Nix build #110383

Merged
merged 1 commit into from Jan 22, 2021
Merged

rust-bindgen: Resolve "/usr/bin/env bash" to fix usage in Nix build #110383

merged 1 commit into from Jan 22, 2021

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Jan 21, 2021

Motivation for this change

rust-bindgen can not be used in a Nix build environment since /usr/bin/env is not available. Resolve path to bash during build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from JohnTitor and Ralith January 21, 2021 19:30
@Ralith
Copy link
Contributor

Ralith commented Jan 21, 2021

I forget where wrapper.sh came from to begin with and it's making me suspicious, but this is certainly an improvement.

@SuperSandro2000 SuperSandro2000 merged commit d78f038 into NixOS:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@JohnTitor JohnTitor Awaiting requested review from JohnTitor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @Ralith @SuperSandro2000