Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icr: 0.8.0 -> unstable-2020-10-05 #110436

Merged
merged 1 commit into from Jan 25, 2021
Merged

icr: 0.8.0 -> unstable-2020-10-05 #110436

merged 1 commit into from Jan 25, 2021

Conversation

peterhoeg
Copy link
Member

Motivation for this change

icr doesn't compile with a recent crystal without this.

Cc @NixOS/crystal-lang

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member 

builder for '/nix/store/l4a2286y8c0ksphmi3gz66nyhmyjlqcc-source.drv' failed with exit code 1; last 8 log lines:

  trying https://github.com/crystal-community/icr/archive/v0.8.0.20201006.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100   138    0   138    0     0    520      0 --:--:-- --:--:-- --:--:--   520
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download source from any mirror

@SuperSandro2000

This comment has been minimized.

Sign in to view
kanashimia
kanashimia reviewed Jan 23, 2021
View reviewed changes
pkgs/development/tools/icr/default.nix Outdated

crystal.buildCrystalPackage rec {
pname = "icr";
version = "0.8.0";
version = "0.8.0.20201006";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.8.0.20201006";
version = "unstable-2020-10-05";

If this is not a tag on github please use unstable-XXXX-XX-XX with the date of the commit.
Commit in question was on the 5th of october.

kanashimia
kanashimia reviewed Jan 23, 2021
View reviewed changes
pkgs/development/tools/icr/default.nix Outdated

crystal.buildCrystalPackage rec {
pname = "icr";
version = "0.8.0";
version = "0.8.0.20201006";

src = fetchFromGitHub {
owner = "crystal-community";
repo = pname;
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
rev = "8c57cd7c1fdf8088cb05c1587bd6c40d244a8a80";

This is what you had in mind, there's no v0.8.0.20201006 tag, see: https://github.com/crystal-community/icr/tags

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messed up the merge, thanks.

@SuperSandro2000 SuperSandro2000 changed the title icr: 0.8.0 -> 0.8.0.20201006 icr: 0.8.0 -> unstable-2020-10-05 Jan 25, 2021
@SuperSandro2000 SuperSandro2000 merged commit 2e80289 into NixOS:master Jan 25, 2021
@peterhoeg peterhoeg deleted the u/icr branch January 26, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanashimia kanashimia kanashimia left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @SuperSandro2000 @kanashimia