Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/modules: add "sdhci_pci" to availableKernelModules #110435

Merged
merged 1 commit into from May 13, 2021
Merged

nixos/modules: add "sdhci_pci" to availableKernelModules #110435

merged 1 commit into from May 13, 2021

Conversation

superloach
Copy link
Contributor

Motivation for this change

Encountered issues booting the live image on an Acer R11 Chromebook (CYAN). Got help from @samueldr on Freenode, and adding this module fixed it. Likely useful for other platforms/situations where booting from SD is necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Encountered issues booting the live image on an Acer R11 Chromebook (CYAN). Got help from @samueldr on Freenode, and adding this module fixed it. Likely useful for other platforms/situations where booting from SD is necessary.
@samueldr
Copy link
Member

Since this is a trivial change which can help people get going with NixOS, it should be backported to the current stable too.

For anyone confused, this simply adds a module (and its dependencies) to the initrd.

@samueldr
Copy link
Member

Hey, sorry it didn't get merged in earlier! Time flies! I assumed someone else would look and merge after I did. I like when PRs have more than two individuals involved.

@samueldr samueldr merged commit 12ede41 into NixOS:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants