New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.ocaml_extlib: 1.7.7 -> 1.7.8 #110374
Conversation
@GrahamcOfBorg build google-drive-ocamlfuse |
@anmonteiro Seems like this beak google-drive-ocamlfuse as mentioned in the linked thread. This probably could be fixed by packaging extlib-compat and using it for google-drive-ocamlfuse. |
Thanks, @sternenseemann. I'm OK waiting for the final deliberation in ocaml/opam-repository#17999 (comment) before this gets merged. |
The option the opam-repository took is to simply patch 1.7.7: ocaml/opam-repository#18041. Furthermore the compat version adds more incompatible modules than previous version of extlib so I would suggest not to use it in NixOS. |
Thanks, Kate! I think taking the same approach and using your patches here could work. I'll look into that later today. |
Note that the two patches I cherry-picked were taken from the upstream's master branch: ygrek/ocaml-extlib#55 |
|
Maybe the upstream patches would apply cleanly on the older versions? Then we wouldn't need to keep two extlib versions around. |
Actually, I do not think older Haxe's are worth including in official nixpkgs, I added all the intermediate versions to local |
Then we probably should do the haxe update in this PR as well. |
just remove extlib-1.7.7 and haxe versions which depend on it (4.0.x and 4.1.x) |
See also #116953. |
closed in favor of #117113 |
Motivation for this change
4.12 support. see ocaml/opam-repository#17998 (comment)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)