Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.IOAsync: 0.77 -> 0.78 #110440

Merged
merged 1 commit into from Jan 23, 2021
Merged

perlPackages.IOAsync: 0.77 -> 0.78 #110440

merged 1 commit into from Jan 23, 2021

Conversation

zakame
Copy link
Member

@zakame zakame commented Jan 22, 2021

Motivation for this change

https://metacpan.org/release/PEVANS/IO-Async-0.78

This includes a minor change for perlPackages.NetAsyncPing to disable network tests (i.e. cannot ping on localhost, and also needs to pull in pkgs.iputils for /bin/ping if otherwise.) Let me know if this particular change needs its own PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner January 22, 2021 06:15
@stigtsp
Copy link
Member

stigtsp commented Jan 22, 2021

Hey.

It would be great to have the perlPackages.NetAsyncPing change as a separate PR, as it doesn't seem related.

@stigtsp
Copy link
Member

stigtsp commented Jan 22, 2021

On a sidenote, it would be great to avoid doCheck=false; if possible, as this can hide problems during mass updates etc. Even just a use_ok() is better than nothing :)

@zakame
Copy link
Member Author

zakame commented Jan 22, 2021

@stigtsp yep, I only made this NetAsyncPing change as it now fails unlike before, indeed better to still keep some basic tests in and just disable/change network tests. Let me spin that off into a separate PR 💪

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110440 run on x86_64-linux 1

10 packages built:
  • perl530Packages.IOAsync
  • perl530Packages.IOAsyncSSL
  • perl530Packages.NetAsyncHTTP
  • perl530Packages.NetAsyncPing
  • perl530Packages.NetAsyncWebSocket
  • perl532Packages.IOAsync
  • perl532Packages.IOAsyncSSL
  • perl532Packages.NetAsyncHTTP
  • perl532Packages.NetAsyncPing
  • perl532Packages.NetAsyncWebSocket

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110440 run on x86_64-darwin 1

10 packages built:
  • perl530Packages.IOAsync
  • perl530Packages.IOAsyncSSL
  • perl530Packages.NetAsyncHTTP
  • perl530Packages.NetAsyncPing
  • perl530Packages.NetAsyncWebSocket
  • perl532Packages.IOAsync
  • perl532Packages.IOAsyncSSL
  • perl532Packages.NetAsyncHTTP
  • perl532Packages.NetAsyncPing
  • perl532Packages.NetAsyncWebSocket

@zakame zakame mentioned this pull request Jan 23, 2021
Merged
10 tasks
stigtsp
stigtsp approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit 2bc16b3 into NixOS:master Jan 23, 2021
@zakame
Copy link
Member Author

zakame commented Jan 23, 2021

Thanks @SuperSandro2000 @stigtsp ! 🎉

@zakame zakame deleted the updates/perl-IO-Async-0.78 branch January 23, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakame @stigtsp @SuperSandro2000