Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.avion: init at 0.10 #110399

Merged
merged 4 commits into from Jan 28, 2021
Merged

python3Packages.avion: init at 0.10 #110399

merged 4 commits into from Jan 28, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 21, 2021

Motivation for this change

Python API for controlling Avi-on Bluetooth dimmers.

https://github.com/mjg59/python-avion

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 21, 2021

Result of nixpkgs-review pr 110399 run on x86_64-linux 1

9 packages built:
  • python37Packages.avion
  • python37Packages.bluepy-devices
  • python37Packages.csrmesh
  • python38Packages.avion
  • python38Packages.bluepy-devices
  • python38Packages.csrmesh
  • python39Packages.avion
  • python39Packages.bluepy-devices
  • python39Packages.csrmesh

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110399 run on x86_64-linux 1

9 packages built:
  • python37Packages.avion
  • python37Packages.bluepy-devices
  • python37Packages.csrmesh
  • python38Packages.avion
  • python38Packages.bluepy-devices
  • python38Packages.csrmesh
  • python39Packages.avion
  • python39Packages.bluepy-devices
  • python39Packages.csrmesh

}:

buildPythonPackage rec {
pname = "bluepy_devices";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pname = "bluepy_devices";
pname = "bluepy-devices";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would revert your previous request to change the pname. Looks like that I misunderstood the comment.

The module name is bluepy_devices. Also, the name of source tarball starts with bluepy_devices* on PyPI. But it seems that PyPI is displaying the name acc. to PEP-0503 while pip install works with bluepy_devices and bluepy-devices.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would revert your previous request to change the pname. Looks like that I misunderstood the comment.

I have talked to jonringer in the meantime and new packages should follow the pep (PEP503?) that converts _ to -.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 110399 run on x86_64-darwin 1

9 packages marked as broken and skipped:
  • python37Packages.avion
  • python37Packages.bluepy-devices
  • python37Packages.csrmesh
  • python38Packages.avion
  • python38Packages.bluepy-devices
  • python38Packages.csrmesh
  • python39Packages.avion
  • python39Packages.bluepy-devices
  • python39Packages.csrmesh

@fabaff
Copy link
Member Author

fabaff commented Jan 26, 2021

bluepy is linux-only. Looks like that I have to mark the packages which depends on it with platforms = platforms.linux; as well.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110399 run on x86_64-linux 1

9 packages built:
  • python37Packages.avion
  • python37Packages.bluepy-devices
  • python37Packages.csrmesh
  • python38Packages.avion
  • python38Packages.bluepy-devices
  • python38Packages.csrmesh
  • python39Packages.avion
  • python39Packages.bluepy-devices
  • python39Packages.csrmesh

@SuperSandro2000 SuperSandro2000 merged commit d0300e7 into NixOS:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants