Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] vlc: 3.0.11.1 -> 3.0.12 #110386

Merged
merged 1 commit into from Jan 24, 2021
Merged

[20.09] vlc: 3.0.11.1 -> 3.0.12 #110386

merged 1 commit into from Jan 24, 2021

Conversation

tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Jan 21, 2021 •
edited

Motivation for this change

Backport of #110379
Security issue https://www.videolan.org/security/sb-vlc3012.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tu-maurice tu-maurice mentioned this pull request Jan 24, 2021
Merged
10 tasks
erictapen
erictapen approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review says:

19 packages built:
libsForQt5.elisa libsForQt5.phonon-backend-vlc libsForQt512.phonon-backend-vlc libsForQt514.elisa libsForQt514.phonon-backend-vlc libvlc megaglest minitube obs-linuxbrowser obs-studio obs-v4l2sink obs-wlrobs pympress python27Packages.python-vlc python37Packages.python-vlc python38Packages.python-vlc strawberry tribler vlc

Only obs-ndi failed which seems to be expected.

@erictapen erictapen merged commit d274f28 into NixOS:release-20.09 Jan 24, 2021
@tu-maurice
Copy link
Contributor Author

@erictapen yes obs-ndi requires ndi which in turn requires manual source download. Sadly I cannot retrieve the sources without specifying personal information, otherwise I would've tested it.

@tu-maurice tu-maurice deleted the 20.09-vlc-3.0.12 branch January 24, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tu-maurice @erictapen @infinisil