Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrdp: fix dead link #110425

Closed
wants to merge 1 commit into from
Closed

xrdp: fix dead link #110425

wants to merge 1 commit into from

Conversation

kvtb
Copy link
Contributor

@kvtb kvtb commented Jan 22, 2021

Forked repos are accessible using parent's user name, so @volth's work could be accessed this way

sha256 unchanged

sha256 unchanged
repo = "xrdp";
rev = "refs/tags/runtime-cfg-path-${version}"; # Fixes https://github.com/neutrinolabs/xrdp/issues/609; not a patch on top of the official repo because "xorgxrdp.configureFlags" above includes "xrdp.src" which must be patched already
rev = "c2f9c44d08264e5374a0db5390dd36b9290885bd"; # Fixes https://github.com/neutrinolabs/xrdp/issues/609; not a patch on top of the official repo because "xorgxrdp.configureFlags" above includes "xrdp.src" which must be patched already
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an really old version and upstream did several releases since then including a CVE one 0.9.13.1 CVE-2022-4044: Local users can perform a buffer overflow attack against the xrdp-sesman service and then impersonate it. We should probably redo the patches on a newer version. Eventually they might also be garbage collected.

Copy link
Contributor Author

@kvtb kvtb Jan 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably redo the patches on a newer version.

Yes.
This is big work.
While this PR fixes a build error caused by 404.
Also it points where to find those patches which have to be redone.

Eventually they might also be garbage collected.

Unlikely, as it is tagged in @volth repo.
We can make another fork and tag this commit too to be sure about GC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volth's account is no longer existing so I would prefer mirroring/forking it to somewhere.

@kvtb kvtb deleted the patch-3 branch January 24, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants