Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridNG] Fix querying %-padding on grid-items. #27811

Merged
merged 1 commit into from Feb 27, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 27, 2021

As above. ComputedCSSPadding will simply look at the available
inline-size of its containing-block. Legacy grid worked by setting the
override containing-block inline-size.

This patch writes back the %-size.

This isn't ideal - in a future world we should answer these queries
directly from the fragment(s), but we aren't there yet.

Bug: 1045599
Change-Id: I3afd8d03b0410dd0e02aba4133de28d92432630e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721043
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858396}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

As above. ComputedCSSPadding will simply look at the available
inline-size of its containing-block. Legacy grid worked by setting the
override containing-block inline-size.

This patch writes back the %-size.

This isn't ideal - in a future world we should answer these queries
directly from the fragment(s), but we aren't there yet.

Bug: 1045599
Change-Id: I3afd8d03b0410dd0e02aba4133de28d92432630e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721043
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858396}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants