Change: Improve console warnings on invalid network commands #8753

ldpl · 2021-02-27T00:37:44Z

Motivation / Problem

Console warnings are missing command number and wording for spectator command warning is very confusing.

%u is not technically correct format for uint32 but openttd doesn't use PRIu32 anywhere

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

The bug fix is important enough to be backported? (label: 'backport requested')
This PR affects the save game format? (label 'savegame upgrade')
This PR affects the GS/AI API? (label 'needs review: Script API')
- ai_changelog.hpp, gs_changelog.hpp need updating.
- The compatibility wrappers (compat_*.nut) need updating.
This PR affects the NewGRF API? (label 'needs review: NewGRF')
- newgrf_debug_data.h may need updating.
- PR must be added to API tracker

glx22 · 2021-02-27T11:27:24Z

Warning displayed in red (color for errors) ?

ldpl · 2021-02-27T11:30:18Z

@glx22 yeah, I found it kinda weird too, but it seems consistent in network code so I left it be.

Change: Improve console warnings on invalid network commands

1154411

LordAro approved these changes Feb 27, 2021

View reviewed changes

TrueBrain added this to the 1.11.0 milestone Feb 27, 2021

TrueBrain merged commit 4fd2eec into OpenTTD:master Feb 27, 2021

ldpl deleted the better-network-warnings branch September 19, 2021 20:02