Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable and move reset session to a function #27805

Merged
merged 1 commit into from Mar 4, 2021

Conversation

k7z45
Copy link
Contributor

@k7z45 k7z45 commented Feb 26, 2021

Per https://github.com/web-platform-tests/wpt/pull/27734/files/1abbaacbe6091d252040e6a5405e4ee90b3a64f8#r583473293
move duplicate code in session and bidi_session fixture into its own function and removed unused variable is_cur_bidi

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Thanks! Just a small nit regarding naming of the argument.

webdriver/tests/support/fixtures.py Outdated Show resolved Hide resolved
@whimboo
Copy link
Contributor

whimboo commented Mar 2, 2021

No, I'm not able to merge PRs. @jgraham would you mind doing that?

@k7z45
Copy link
Contributor Author

k7z45 commented Mar 4, 2021

@stephenmcgruer

Hi Stephen,

Could you or @jgraham help merging this PR, please?

@stephenmcgruer stephenmcgruer merged commit b3f0923 into web-platform-tests:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants