Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css-sizing/image-min-max-content-intrinsic-size-change-00*html wrong? #27810

Closed
davidsgrogan opened this issue Feb 26, 2021 · 1 comment · Fixed by #27971
Closed

css-sizing/image-min-max-content-intrinsic-size-change-00*html wrong? #27810

davidsgrogan opened this issue Feb 26, 2021 · 1 comment · Fixed by #27971
Labels
css-sizing

Comments

@davidsgrogan
Copy link
Member

Even though Chrome and Firefox both pass, I think these are wrong, for the same reason as https://bugzilla.mozilla.org/show_bug.cgi?id=1670151.

For example, after script finishes, image-min-max-content-intrinsic-size-change-001.html is essentially

<img src="/css/support/60x60-green.png" style="height: 30px; width: 30px; min-width: min-content;">

The test asserts that the image is 60x30 presumably because min-width:min-content is expected to be 60px.

But as https://bugzilla.mozilla.org/show_bug.cgi?id=1670151 says, min-width:min-content is specified to return 30px, so the final image size should be 30x30.

These people might have insight here:
@bfgeek because he recently made these tests pass in Blink
@BorisChiou because he's been looking into https://bugzilla.mozilla.org/show_bug.cgi?id=1670151

Thoughts? If you agree these tests are wrong, I will fix them.
@BorisChiou
Copy link
Member

Yes. I think these are wrong now. The natural ratio should affect the intrinsic size, based on w3c/csswg-drafts#5032. (Though we miss the ability to use the natural size after this behavior change on replaced elements.)

Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1135287
cc @emilio

chromium-wpt-export-bot pushed a commit that referenced this issue Mar 9, 2021
@davidsgrogan @chromium-wpt-export-bot
[css-images] Fix some image tests that assert buggy behavior
a39b68a 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes #27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Merged
chromium-wpt-export-bot pushed a commit that referenced this issue Mar 10, 2021
@davidsgrogan @chromium-wpt-export-bot
[css-images] Fix some image tests that assert buggy behavior
b2c1953 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes #27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
chromium-wpt-export-bot pushed a commit that referenced this issue Mar 10, 2021
@davidsgrogan @chromium-wpt-export-bot
[css-images] Fix some image tests that assert buggy behavior
20f975f 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes #27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745648
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861655}
chromium-wpt-export-bot pushed a commit that referenced this issue Mar 10, 2021
@davidsgrogan @chromium-wpt-export-bot
[css-images] Fix some image tests that assert buggy behavior
68f20af 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes #27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745648
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861655}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue Mar 11, 2021
@davidsgrogan
[css-images] Fix some image tests that assert buggy behavior
23ec28b 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes web-platform-tests/wpt#27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745648
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861655}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 19, 2021
@davidsgrogan @moz-wptsync-bot
Bug 1697662 [wpt PR 27971] - [css-images] Fix some image tests that a…
6e80ce6 
…ssert buggy behavior, a=testonly

Automatic update from web-platform-tests
[css-images] Fix some image tests that assert buggy behavior

These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes web-platform-tests/wpt#27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745648
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861655}

--

wpt-commits: 68f20af4455a3f4abd92b2e0c2bcde9bb7184600
wpt-pr: 27971
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@davidsgrogan
[css-images] Fix some image tests that assert buggy behavior
cae7b74 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes web-platform-tests/wpt#27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745648
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861655}
GitOrigin-RevId: 23ec28b727fd8cf74f3f049ffab2be4030190962
ns-rsilva pushed a commit to ns-rsilva/chromium that referenced this issue Apr 25, 2024
@davidsgrogan
[css-images] Fix some image tests that assert buggy behavior
52c167c 
These tests depend on a bug that is present in both chrome and firefox,
which causes the intrinsic min/max sizes to be the image's natural width
instead of its transferred specified width. E.g. in Chrome/Firefox
today, <img src="100x100.png" style="height: 200px"> reports its min/max
intrinsic size to be 100 instead of the correct 200.

This bug is fixed in ReplacedNG.

Fixes web-platform-tests/wpt#27810

Bug: 1135287
Change-Id: If287de6220335f08248bd39655828d518b876258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745648
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861655}

Former-commit-id: 23ec28b727fd8cf74f3f049ffab2be4030190962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-sizing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-images] Fix some image tests that assert buggy behavior web-platform-tests/wpt
3 participants
@foolip @davidsgrogan @BorisChiou