Repaint when bgcolor animation is triggered #27666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 17, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2698847
branch
4 times, most recently
from
051eed8
to
90f7561
Compare
Right now when a bgcolor animation/transition is triggered, such as hovering over an element, we do not request a repaint of the element and thus we cannot composite the bgcolor animation. This CL fixes the problem by triggering a full repaint. Bug: 1177320 Change-Id: I87dff5c11d109fc97f41c9b49e13b81613004281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698847 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#857877}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2698847
branch
from
90f7561
to
930ce67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when a bgcolor animation/transition is triggered, such
as hovering over an element, we do not request a repaint of the
element and thus we cannot composite the bgcolor animation.
This CL fixes the problem by triggering a full repaint.
Bug: 1177320
Change-Id: I87dff5c11d109fc97f41c9b49e13b81613004281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698847
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857877}