Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Town name generator for Spanish (Spain) #8683

Closed
wants to merge 1 commit into from
Closed

Feature: Town name generator for Spanish (Spain) #8683

wants to merge 1 commit into from

Conversation

perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Feb 17, 2021 •
edited

Motivation / Problem

There is no town name generator for Spanish (Spain). Instead, there is a town generator for Latin-American Spanish with real city names. This PR adds a town generator for Spanish (Spain) not just with real names but a generator with prefixes and suffixes like other languages like Italian, Catalan, etc.

Description

Adding a town generator for Spanish (Spain) not just with real names but a generator with prefixes and suffixes like other languages like Italian, Catalan, etc.

Limitations

None

Checklist for review

I've tested it switching the game language to another one as well.

Followed instructions by @James103 in the comment section to see if it can generate over 5000 town names and it can!

@perezdidac perezdidac marked this pull request as ready for review February 17, 2021 05:24
@James103
Copy link
Contributor

Does your Spanish (Spain) town name generator generate at least 5,000 unique names? You can test this by doing the following:

  1. From the main menu, select "New Game".
  2. In the world generation window, set "No. of towns" = "Custom (5000)".
  3. Set map size to 4096 x 4096, sea level to "Very Low", and terrain type to "Very Flat".
  4. Click "Generate".
  5. In game, open the fund new town window. You may have to change the setting "Allow funding towns in game" to "Allowed".
  6. Look at the town name input box. If it is empty, even after hitting "Random name", then there are no more unique names available.

@perezdidac
Copy link
Contributor Author

perezdidac commented Feb 17, 2021 •
edited

Does your Spanish (Spain) town name generator generate at least 5,000 unique names? You can test this by doing the following:

  1. From the main menu, select "New Game".
  2. In the world generation window, set "No. of towns" = "Custom (5000)".
  3. Set map size to 4096 x 4096, sea level to "Very Low", and terrain type to "Very Flat".
  4. Click "Generate".
  5. In game, open the fund new town window. You may have to change the setting "Allow funding towns in game" to "Allowed".
  6. Look at the town name input box. If it is empty, even after hitting "Random name", then there are no more unique names available.

Checked! It generates more.

@perezdidac perezdidac closed this Feb 17, 2021
@perezdidac perezdidac reopened this Feb 17, 2021
@perezdidac perezdidac marked this pull request as draft February 17, 2021 06:21
@perezdidac perezdidac marked this pull request as ready for review February 17, 2021 06:42
@frosch123
Copy link
Member

Sorry, we do not accept any new town name generators in C++.
Town names can be provided via NewGRF; there is even already a "Spanish Town Names" NewGRF on BaNaNaS.

@frosch123 frosch123 closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perezdidac @James103 @frosch123