Feature: [GS] Allow non-question type windows to have no buttons #8638
Conversation
|
As you can see in the pictures above, you have a message confirmation button everywhere. :) |
|
Let's compare oranges with oranges, not with a coffee mug. |
|
Small-caliber news, frequent ones don't actually require it. One problem with closing the window is also that closing by RMB (the best change of the last 6 years for me) is not the default. This is a very big improvement not available to beginners. Also for this reason, removing the larger closing space of the window will not be good in my opinion. Generally, it is not important to me, but I am writing it with people starting their adventure with the game in mind. |
ldpl
force-pushed
the
gs-no-buttons-popup
branch
from
8283b47 to
cfdb937
Compare
ldpl
force-pushed
the
gs-no-buttons-popup
branch
from
cfdb937 to
fac3c53
Compare
|
One reason to not have buttons for some errors is that OpenTTD spams more than enough windows as it is, no need to take even more screen space for utterly pointless buttons. |
|
I hope, this will not getting a boomerang UI-wise because the close-window-cross-button is in comparision to the now removed OK-button a really small sized click target. When an overlay has a ok-button, one as a player has three choices to close the overlay window, waiting until the window disappears, pushing the small close-window-cross-button or pushing the much bigger OK-button. Without the OK-button only waiting or pushing the small sized close-window-cross-button left. We will see. |
|
It's not been removed, merely the option to have one has been removed. It's on the GS author whether they use it or not, as appropriate. I agree that the close button is small, but there are 'workarounds' - increased UI size or there's a setting to close windows on right-click too |
|
Also please remember that we have many windows without buttons already. This just brings GSes on-par with what OpenTTD does itself, being more consistent in UI, basically. |
|
A right click anywhere on the window should also close it. |
Motivation / Problem
3 out of 4 gs "question" window types (info, warning and error) aren't really questions and likely don't need any buttons but are forced by gs api to have at least one.
Description
GS for testing: test-question-no-buttons.zip
Limitations
It still looks somewhat different from the regular error because of how paddings are calculated but I decided to address it in a separate pr later.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.