Fix: Desert/rainforest data coordinate 'y' is off by 1 when their 'x' coordinate is negative #8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why you've changed the signs of the values, rather than just incrementing them like in the commit you linked? |
SamuXarick
force-pushed
the
genland.h-data-was-off-by-1
branch
from
d0aae43
to
109b733
Compare
… coordinate is negative
SamuXarick
force-pushed
the
genland.h-data-was-off-by-1
branch
from
109b733
to
32b270e
Compare
SamuXarick
changed the title
I was lazy, now it's incremented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The data that is used for generating desert or rainforest in sub-tropical is a list of TileIndexDiffC offsets, and visually look like a circumference.
The half towards NE looks misaligned.
It is similar to a bug that was uncovered back in 4846c7e for oil rig layout, in which it looked like this:
And once fixed, it looked like this:
This PR fixes the offset layout in the same manner as the oil rig layout.
Description
Make it aligned.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.