Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deadd-notification-center: 1.7.2 -> 1.7.3 #109901

Merged
merged 1 commit into from Jan 20, 2021
Merged

deadd-notification-center: 1.7.2 -> 1.7.3 #109901

merged 1 commit into from Jan 20, 2021

Conversation

Pacman99
Copy link
Contributor

@Pacman99 Pacman99 commented Jan 19, 2021 •
edited

Motivation for this change

Deadd-notification-center was updated a couple months ago(I'm a bit late with this). Still can't build it from source(broken haskell dependencies), but I made the package a bit simpler by fetching it from github and using the binary built with github actions. Also added hicolor-icon-theme and wrapGAppsHook, not sure if the latter is necessary but it is a gtk app.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Pacman99 Pacman99 requested a review from teto January 19, 2021 05:55
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109901 run on x86_64-linux 1

1 package built:
  • deadd-notification-center

@SuperSandro2000 SuperSandro2000 merged commit 6cd64da into NixOS:master Jan 20, 2021
@Pacman99 Pacman99 deleted the deadd-update branch January 24, 2021 03:00
@teto
Copy link
Member

teto commented Feb 15, 2021

feel free to ignore the following question: how do you run the service ? I've tried adding

    dbus.packages = [
      pkgs.deadd-notification-center
    ];

but dbus-monitor returns

   string "Could not get owner of name 'org.freedesktop.Notifications': no such name"
method call time=1613388383.898110 sender=:1.73 -> destination=org.freedesktop.Notifications serial=6 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=GetServerInformation
error time=1613388383.898117 sender=org.freedesktop.DBus -> destination=:1.73 error_name=org.freedesktop.DBus.Error.ServiceUnknown reply_serial=6
   string "The name org.freedesktop.Notifications was not provided by any .service files"

after a notify-send.

@Pacman99
Copy link
Contributor Author

Pacman99 commented Feb 15, 2021 •
edited

I made a mistake in the package and used the systemd service file for dbus. I filed a PR to fix here: #113222
Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pacman99 @SuperSandro2000 @teto