Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] fix shell.nix #109816

Merged
merged 1 commit into from Jan 19, 2021
Merged

[doc] fix shell.nix #109816

merged 1 commit into from Jan 19, 2021

Conversation

greizgh
Copy link
Contributor

@greizgh greizgh commented Jan 18, 2021

Motivation for this change

The documentation mentions nix-shell usage.
However, since #105986 the overridden buildInputs attribute does not exist the derivation, causing an error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Jan 19, 2021

buildInputs = (x.buildInputs or []) ++ [ pkgs.xmloscopy pkgs.ruby ];

@veprbl veprbl merged commit 94f850c into NixOS:master Jan 19, 2021
@greizgh greizgh deleted the fix-doc-shell branch January 20, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants