Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os-specific/linux/kernel: fix using manual config #109806

Closed
wants to merge 1 commit into from
Closed

os-specific/linux/kernel: fix using manual config #109806

wants to merge 1 commit into from

Conversation

S-NA
Copy link
Contributor

@S-NA S-NA commented Jan 18, 2021

Motivation for this change

This fixes the "called without required argument 'lib'," error that
occurs when using a manual kernel config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@S-NA
os-specific/linux/kernel: fix using manual config
a505101 
This fixes the "called without required argument 'lib'," error that
occurs when using a manual kernel config.
@SuperSandro2000
Copy link
Member

@S-NA please fix the eval error.

@S-NA
Copy link
Contributor Author

S-NA commented Jan 18, 2021

On further examination, my error seems to be from usage of linuxManualConfig "incorrectly". When upgrading my system to master my prior usage ended up being breaking. It lacked having inherit lib, seems documentation needs updating since #108938 wants to have lib available on the top-level.

Sorry for the noise.

@S-NA S-NA closed this Jan 18, 2021
@S-NA S-NA deleted the fix-linux-manual-config branch January 18, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@siraben siraben Awaiting requested review from siraben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@S-NA @SuperSandro2000