Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/podman: readd rootless runc test #109855

Merged
merged 1 commit into from Jan 20, 2021
Merged

nixos/podman: readd rootless runc test #109855

merged 1 commit into from Jan 20, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 18, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/podman

@zowoq
nixos/podman: readd rootless runc test
34a2071 
use `loginctl enable-linger` to create systemd session
@zowoq
Copy link
Contributor Author

zowoq commented Jan 19, 2021

@ofborg test podman

saschagrunert
saschagrunert approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq zowoq merged commit b46b3d9 into NixOS:master Jan 20, 2021
@zowoq zowoq deleted the podman-runc-test branch January 20, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @bachp @saschagrunert