Fix recent NewGRF spec addition to make it less surprising/arbitrary #8590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While adding recent NewGRF features to NML, I came across #8079.
To translate NewGRF jargon into English, it adds this footnote to the API:
As a NewGRF author I would not expect the "second output cargo" to behave any different from other output cargos, just because my industry happens to be built on water.
From a NML perspective this flag could be considered as "enable work-around for OpenTTD bug", so NML could enable it silently by default.
However, it's both easier and likely better to give the flag some intention, and implement it with less arbitrary conditions.
Description
The original intention of the special case in OpenTTD seems to be the original oil rig.
The oil rig features passengers as "support cargo", which are not supposed to be produced en-mass.
This PR changes the behavior of the flag added in #8079:
This behavior is easier to explain, and likely also fits better what a NewGRF industry may want to achieve.
The "passenger" condition only triggers for real passenger, not for "tourists" or other cargos with "passenger" cargo class.
Though industry sets that feature "worker mechanics" always have custom production mechanics, so that smooth economy and this flag does not apply anyway.
In summary:
Limitations
N/A
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.