Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tecoc: 20150606 -> unstable-2020-11-03 #109848

Merged
merged 1 commit into from Jan 19, 2021
Merged

tecoc: 20150606 -> unstable-2020-11-03 #109848

merged 1 commit into from Jan 19, 2021

Conversation

AndersonTorres
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: lua label Jan 18, 2021
@AndersonTorres
Copy link
Member Author

Why does it complain about tangranm??

https://gist.github.com/GrahamcOfBorg/2f7d2ee6a76622b59c34a45dba757dd0

@SuperSandro2000
Copy link
Member

Why does it complain about tangranm??

gist.github.com/GrahamcOfBorg/2f7d2ee6a76622b59c34a45dba757dd0

An old PR got merged. Fixing it right now.

@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot added the 6.topic: lua label Jan 19, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 19, 2021
View reviewed changes
pkgs/top-level/lua-packages.nix Outdated
@@ -5,13 +5,29 @@
for each package in a separate file: the call to the function would
be almost as must code as the function itself. */

{ fetchurl, stdenv, lua, unzip, pkg-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer it if you would revert this change here.

SuperSandro2000
SuperSandro2000 reviewed Jan 19, 2021
View reviewed changes
pkgs/applications/networking/instant-messengers/tangram/default.nix Outdated
@@ -15,7 +31,14 @@ stdenv.mkDerivation rec {
fetchSubmodules = true;
};

buildInputs = [ gdk-pixbuf gjs glib gsettings-desktop-schemas gtk3 webkitgtk ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anything got changed here. It would be probably better to revert this.

@AndersonTorres AndersonTorres changed the title Pkgconfig -> pkg-config tecoc: 20150606 -> unstable-2020-11-03 Jan 19, 2021
@AndersonTorres AndersonTorres merged commit 725a4da into NixOS:master Jan 19, 2021
@ofborg ofborg bot removed the 6.topic: lua label Jan 19, 2021
@AndersonTorres AndersonTorres deleted the pkgconfig->pkg-config branch February 19, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @SuperSandro2000