Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wesnoth: 1.14.14 -> 1.14.15 #109847

Merged
merged 1 commit into from Jan 26, 2021
Merged

Wesnoth: 1.14.14 -> 1.14.15 #109847

merged 1 commit into from Jan 26, 2021

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Jan 18, 2021

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar January 18, 2021 23:18
@kampka kampka changed the title Wesnoth Wesnoth: 1.14.14 -> 1.14.15 Jan 19, 2021
@Pacman99
Copy link
Contributor

Result of nixpkgs-review pr 109847 run on x86_64-linux 1

1 package built:
  • wesnoth (wesnoth-dev)

1 similar comment
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 109847 run on x86_64-linux 1

1 package built:
  • wesnoth (wesnoth-dev)

@aanderse
Copy link
Member

Merging based on approval by @tomberek 👍

@aanderse aanderse merged commit 71a9046 into NixOS:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kampka @Pacman99 @tomberek @aanderse