Please replace the jre in metabase with jdk11 instead.

Please replace the jre in metabase with jdk11 instead.

While I see some advantage of specifying the version inside the package, there is also an advantage of specifying it in all-packages.nix.

There are many other packages that specify the jre/jdk version like this in all-packages.nix, and also when this topic was recently discussed (https://discourse.nixos.org/t/package-version-arguments-vs-generic-package-arguments/9071) there was no clear preference.

I'll make the change, but I don't like adding extra round-trips to PR's like this. It discourages contributions without good reason IMHO.

Please replace the jre in metabase with jdk11 instead.

While I see some advantage of specifying the version inside the package, there is also an advantage of specifying it in all-packages.nix.

There are many other packages that specify the jre/jdk version like this in all-packages.nix, and also when this topic was recently discussed (discourse.nixos.org/t/package-version-arguments-vs-generic-package-arguments/9071) there was no clear preference.

I'll make the change, but I don't like adding extra round-trips to PR's like this. It discourages contributions without good reason IMHO.

Good to know that and good reason. If we follow that discussion we would need to replace jre with jdk. My main problem was with replacing jre with jdk which is not intuitiv.

But This should be fine right now.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109832 run on x86_64-linux 1