Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.sqlite-utils: 3.2 -> 3.3 #109830

Merged
merged 1 commit into from Jan 18, 2021
Merged

python37Packages.sqlite-utils: 3.2 -> 3.3 #109830

merged 1 commit into from Jan 18, 2021

Conversation

meatcar
Copy link
Contributor

@meatcar meatcar commented Jan 18, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@meatcar
python37Packages.sqlite-utils: 3.2 -> 3.3
b6eab73 
Re-enable tests that were fixed in sqlite-utils v3.1.1.
@meatcar
Copy link
Contributor Author

meatcar commented Jan 18, 2021

Result of nixpkgs-review pr 109830 run on x86_64-linux 1

3 packages built:
  • python37Packages.sqlite-utils
  • sqlite-utils (python38Packages.sqlite-utils)
  • python39Packages.sqlite-utils

@meatcar
Copy link
Contributor Author

meatcar commented Jan 18, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 18, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 18, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109830 run on x86_64-linux 1

3 packages built:
  • python37Packages.sqlite-utils
  • sqlite-utils (python38Packages.sqlite-utils)
  • python39Packages.sqlite-utils

@SuperSandro2000 SuperSandro2000 merged commit 728eb41 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meatcar @SuperSandro2000