Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-manager: 2020-09-06 -> 2020-01-16 #109825

Merged
merged 1 commit into from Jan 20, 2021

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 18, 2021

Motivation for this change

It has been a while since the last update. This includes some new
features [1] and at least one compatibility fix [2].

[1] https://github.com/nix-community/home-manager/blob/73506f947c3a2f63306233358231b069865d1d56/modules/misc/news.nix#L1653
[2] nix-community/home-manager#1703

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It has been a while since the last update. This includes some new
features [1] and at least one compatibility fix [2].

[1] https://github.com/nix-community/home-manager/blob/73506f947c3a2f63306233358231b069865d1d56/modules/misc/news.nix#L1653
[2] nix-community/home-manager#1703
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109825 run on x86_64-linux 1

1 package built:
  • home-manager

@timokau timokau merged commit 458b655 into NixOS:master Jan 20, 2021
@timokau timokau deleted the home-manager-2021-01-16 branch January 20, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants