powerdns-admin: init at 0.2.3 #109841

zhaofengli · 2021-01-18T22:32:34Z

Motivation for this change

PowerDNS-Admin is a web interface for PowerDNS. This PR also adds new Python modules required by the application.

Things done

zhaofengli · 2021-02-19T08:21:46Z

Rebased with stdenv.lib fixes for #108938. Also fixed font copying in asset packaging.

nixos-discourse · 2021-02-19T08:24:52Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/468

pkgs/applications/networking/powerdns-admin/update-asset-deps.sh

pkgs/development/python-modules/xmlsec/default.nix

SuperSandro2000 · 2021-02-19T09:32:25Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109841 run on x86_64-linux 1

16 packages built:

powerdns-admin
python37Packages.flask-seasurf
python37Packages.flask-sslify
python37Packages.lima
python37Packages.python3-saml
python37Packages.xmlsec
python38Packages.flask-seasurf
python38Packages.flask-sslify
python38Packages.lima
python38Packages.python3-saml
python38Packages.xmlsec
python39Packages.flask-seasurf
python39Packages.flask-sslify
python39Packages.lima
python39Packages.python3-saml
python39Packages.xmlsec

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

powerdns-admin:

patchPhase should not be overridden, use postPatch instead.

Near pkgs/applications/networking/powerdns-admin/default.nix:80:3:

   |
80 |   patchPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/applications/networking/powerdns-admin/default.nix:84:3:

   |
84 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

python37Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/flask-seasurf/default.nix:1:8:

  |
1 | { lib, stdenv, fetchFromGitHub, buildPythonPackage, flask }:
  |        ^

python37Packages.flask-sslify:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/flask-sslify/default.nix:1:8:

  |
1 | { lib, stdenv, fetchPypi, buildPythonPackage, flask }:
  |        ^

python37Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/python3-saml/default.nix:1:8:

  |
1 | { lib, stdenv, fetchFromGitHub, buildPythonPackage, isPy3k,
  |        ^

python37Packages.xmlsec:

Unused argument: stdenv.
Near pkgs/development/python-modules/xmlsec/default.nix:1:14:

  |
1 | { pkgs, lib, stdenv, fetchPypi, buildPythonPackage, pytestCheckHook,
  |              ^

python38Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/flask-seasurf/default.nix:1:8:

  |
1 | { lib, stdenv, fetchFromGitHub, buildPythonPackage, flask }:
  |        ^

python38Packages.flask-sslify:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/flask-sslify/default.nix:1:8:

  |
1 | { lib, stdenv, fetchPypi, buildPythonPackage, flask }:
  |        ^

python38Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/python3-saml/default.nix:1:8:

  |
1 | { lib, stdenv, fetchFromGitHub, buildPythonPackage, isPy3k,
  |        ^

python38Packages.xmlsec:

Unused argument: stdenv.
Near pkgs/development/python-modules/xmlsec/default.nix:1:14:

  |
1 | { pkgs, lib, stdenv, fetchPypi, buildPythonPackage, pytestCheckHook,
  |              ^

python39Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/flask-seasurf/default.nix:1:8:

  |
1 | { lib, stdenv, fetchFromGitHub, buildPythonPackage, flask }:
  |        ^

python39Packages.flask-sslify:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/flask-sslify/default.nix:1:8:

  |
1 | { lib, stdenv, fetchPypi, buildPythonPackage, flask }:
  |        ^

python39Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
Unused argument: stdenv.
Near pkgs/development/python-modules/python3-saml/default.nix:1:8:

  |
1 | { lib, stdenv, fetchFromGitHub, buildPythonPackage, isPy3k,
  |        ^

python39Packages.xmlsec:

Unused argument: stdenv.
Near pkgs/development/python-modules/xmlsec/default.nix:1:14:

  |
1 | { pkgs, lib, stdenv, fetchPypi, buildPythonPackage, pytestCheckHook,
  |              ^

zhaofengli · 2021-02-19T10:23:17Z

Ok, force-pushed with the requested changes. For xmlsec, I agree it's a little messy, but I'm not entirely sure how to get it to compile without having the native packages pulled in (both pkgs.pkg-config as well as pythonPackages.pkgconfig are required in my testing).

SuperSandro2000 · 2021-02-19T12:36:05Z

Ok, force-pushed with the requested changes. For xmlsec, I agree it's a little messy, but I'm not entirely sure how to get it to compile without having the native packages pulled in (both pkgs.pkg-config as well as pythonPackages.pkgconfig are required in my testing).

Probably the package is using pkg-config somewhere directly instead of through pkgconfig. Should not be a blocker.

SuperSandro2000 · 2021-02-19T15:02:17Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109841 run on x86_64-darwin 1

15 packages built:

python37Packages.flask-seasurf
python37Packages.flask-sslify
python37Packages.lima
python37Packages.python3-saml
python37Packages.xmlsec
python38Packages.flask-seasurf
python38Packages.flask-sslify
python38Packages.lima
python38Packages.python3-saml
python38Packages.xmlsec
python39Packages.flask-seasurf
python39Packages.flask-sslify
python39Packages.lima
python39Packages.python3-saml
python39Packages.xmlsec

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python37Packages.flask-sslify:

Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/flask-sslify/default.nix:1:39:

  |
1 | { lib, fetchPypi, buildPythonPackage, pytestCheckHook, flask }:
  |                                       ^

python37Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.flask-sslify:

Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/flask-sslify/default.nix:1:39:

  |
1 | { lib, fetchPypi, buildPythonPackage, pytestCheckHook, flask }:
  |                                       ^

python38Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.flask-sslify:

Unused argument: pytestCheckHook.
Near pkgs/development/python-modules/flask-sslify/default.nix:1:39:

  |
1 | { lib, fetchPypi, buildPythonPackage, pytestCheckHook, flask }:
  |                                       ^

python39Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

zhaofengli · 2021-02-19T17:10:42Z

Thanks! I removed the unused parameter from flask-sslify. The other "Add a checkPhase for tests" errors seem to be false-positives because tests are indeed run when they are built.

pkgs/development/python-modules/xmlsec/default.nix

pkgs/development/python-modules/python3-saml/default.nix

pkgs/applications/networking/powerdns-admin/update-asset-deps.sh

pkgs/development/python-modules/xmlsec/default.nix

zhaofengli · 2021-02-22T01:17:59Z

Well, I was looking at the wrong place 🤦 Fix applied.

SuperSandro2000 · 2021-02-22T07:08:05Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109841 run on x86_64-darwin 1

15 packages built:

python37Packages.flask-seasurf
python37Packages.flask-sslify
python37Packages.lima
python37Packages.python3-saml
python37Packages.xmlsec
python38Packages.flask-seasurf
python38Packages.flask-sslify
python38Packages.lima
python38Packages.python3-saml
python38Packages.xmlsec
python39Packages.flask-seasurf
python39Packages.flask-sslify
python39Packages.lima
python39Packages.python3-saml
python39Packages.xmlsec

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python37Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

The always helpfull nixpkgs-hammering reminded me that we should add pythonImportsCheck and then I think this is done or almost done.

zhaofengli · 2021-02-22T07:27:48Z

Alright, added. I thought those were not necessary as tests are run already, but doesn't hurt to have them I guess 😛

SuperSandro2000 · 2021-02-22T07:50:23Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109841 run on x86_64-linux 1

16 packages built:

powerdns-admin
python37Packages.flask-seasurf
python37Packages.flask-sslify
python37Packages.lima
python37Packages.python3-saml
python37Packages.xmlsec
python38Packages.flask-seasurf
python38Packages.flask-sslify
python38Packages.lima
python38Packages.python3-saml
python38Packages.xmlsec
python39Packages.flask-seasurf
python39Packages.flask-sslify
python39Packages.lima
python39Packages.python3-saml
python39Packages.xmlsec

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python37Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python38Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.flask-seasurf:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

python39Packages.python3-saml:

Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

zhaofengli · 2021-02-22T07:52:48Z

python38Packages.flask-seasurf:
Add a checkPhase for tests, or at least pythonImportsCheck.

Hmm, the pythonImportsChecks are definitely there. Not sure what's happening here.

SuperSandro2000 · 2021-02-22T13:17:37Z

python38Packages.flask-seasurf:
Add a checkPhase for tests, or at least pythonImportsCheck.

Hmm, the pythonImportsChecks are definitely there. Not sure what's happening here.

It probably used the changes before you added the checks. I want to add a link to the commit that was used to generate the report but that maybe takes a bit. Taking a look at the other changes later.

pkgs/development/python-modules/xmlsec/default.nix

SuperSandro2000 · 2021-03-07T03:22:05Z

@zhaofengli please resolve the merge conflict.

zhaofengli · 2021-03-07T03:32:53Z

Sure, rebased and applied suggested changes.

SuperSandro2000 · 2021-03-07T19:16:44Z

error: build of '/nix/store/75q369al977y8q8h9b1cgj6a5frn6vxn-python3.8-python3-saml-1.10.0.drv' on 'ssh://clara.r' failed: error: --- Error --- nix-daemon
builder for '/nix/store/75q369al977y8q8h9b1cgj6a5frn6vxn-python3.8-python3-saml-1.10.0.drv' failed with exit code 1; last 10 log lines:
  adding 'python3_saml-1.10.0.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/source/dist /build/source
  Processing ./python3_saml-1.10.0-py3-none-any.whl
  Requirement already satisfied: xmlsec>=1.0.5 in /nix/store/gknwvwa2g06r9l2469km6yb6qva8ffvj-python3.8-xmlsec-1.3.9/lib/python3.8/site-packages (from python3-saml==1.10.0) (1.3.9)
  ERROR: Could not find a version that satisfies the requirement defusedxml==0.6.0 (from python3-saml)
  ERROR: No matching distribution found for defusedxml==0.6.0
builder for '/nix/store/75q369al977y8q8h9b1cgj6a5frn6vxn-python3.8-python3-saml-1.10.0.drv' failed with exit code 1
cannot build derivation '/nix/store/61dykksav9ih12pa0bms62a7rlyj4s9z-powerdns-admin-assets-0.2.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/g9rpjamn7hmlcrq9fimmz2d03pvb50vf-powerdns-admin-0.2.3.drv': 2 dependencies couldn't be built
error: build of '/nix/store/g9rpjamn7hmlcrq9fimmz2d03pvb50vf-powerdns-admin-0.2.3.drv' failed

I think you need to relax the version requirement.

zhaofengli · 2021-03-07T21:25:04Z

@SuperSandro2000 Ok, looks like the upstream has removed the dependency and the commit doesn't introduce any API/functionality changes, so I've added the patch. Also took the liberty to bump it to 1.10.1.

SuperSandro2000 · 2021-03-08T20:45:31Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109841 run on x86_64-linux 1

11 packages built:

powerdns-admin
python38Packages.flask-seasurf
python38Packages.flask-sslify
python38Packages.lima
python38Packages.python3-saml
python38Packages.xmlsec
python39Packages.flask-seasurf
python39Packages.flask-sslify
python39Packages.lima
python39Packages.python3-saml
python39Packages.xmlsec

zhaofengli requested review from FRidh and jonringer as code owners January 18, 2021 22:32

zhaofengli force-pushed the powerdns-admin branch from fcf8676 to 1a8be30 Compare January 18, 2021 22:41

ofborg bot added 6.topic: python 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jan 18, 2021

zhaofengli force-pushed the powerdns-admin branch 4 times, most recently from f6a6925 to 83761d3 Compare February 19, 2021 08:02

SuperSandro2000 requested changes Feb 19, 2021

View reviewed changes

zhaofengli force-pushed the powerdns-admin branch from 83761d3 to 931ed98 Compare February 19, 2021 10:20

zhaofengli force-pushed the powerdns-admin branch from 931ed98 to d21d6ef Compare February 19, 2021 17:08

SuperSandro2000 requested changes Feb 21, 2021

View reviewed changes

zhaofengli force-pushed the powerdns-admin branch 2 times, most recently from dd18300 to f711134 Compare February 21, 2021 17:11

SuperSandro2000 requested changes Feb 22, 2021

View reviewed changes

pkgs/development/python-modules/xmlsec/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/xmlsec/default.nix Outdated Show resolved Hide resolved

zhaofengli force-pushed the powerdns-admin branch from f711134 to bd559e0 Compare February 22, 2021 01:17

zhaofengli force-pushed the powerdns-admin branch from bd559e0 to 9728fe2 Compare February 22, 2021 07:26

SuperSandro2000 reviewed Mar 7, 2021

View reviewed changes

pkgs/development/python-modules/xmlsec/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/xmlsec/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 added the 2.status: merge conflict label Mar 7, 2021

zhaofengli force-pushed the powerdns-admin branch from 9728fe2 to e9b80b9 Compare March 7, 2021 03:32

ofborg bot added 10.rebuild-darwin: 1-10 and removed 2.status: merge conflict 10.rebuild-darwin: 11-100 labels Mar 7, 2021

zhaofengli added 7 commits March 7, 2021 13:11

maintainers: add zhaofengli

5b75519

python3Packages.lima: init at 0.5

70fc42b

python3Packages.flask-seasurf: init at 0.3.0

0da9e83

pythonPackages.flask-sslify: init at 0.1.5

120bc67

pythonPackages.xmlsec: init at 1.3.9

64cfeef

python3Packages.python3-saml: init at 1.10.1

6bc385a

powerdns-admin: init at 0.2.3

0aa2fcb

zhaofengli force-pushed the powerdns-admin branch from e9b80b9 to 0aa2fcb Compare March 7, 2021 21:25

SuperSandro2000 merged commit 05c92a5 into NixOS:master Mar 8, 2021

zhaofengli deleted the powerdns-admin branch March 8, 2021 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

powerdns-admin: init at 0.2.3 #109841

powerdns-admin: init at 0.2.3 #109841

zhaofengli commented Jan 18, 2021

zhaofengli commented Feb 19, 2021

nixos-discourse commented Feb 19, 2021

SuperSandro2000 commented Feb 19, 2021

zhaofengli commented Feb 19, 2021 •

edited

SuperSandro2000 commented Feb 19, 2021

SuperSandro2000 commented Feb 19, 2021

zhaofengli commented Feb 19, 2021

zhaofengli commented Feb 22, 2021

SuperSandro2000 commented Feb 22, 2021 •

edited

zhaofengli commented Feb 22, 2021

SuperSandro2000 commented Feb 22, 2021

zhaofengli commented Feb 22, 2021

SuperSandro2000 commented Feb 22, 2021

SuperSandro2000 commented Mar 7, 2021

zhaofengli commented Mar 7, 2021

SuperSandro2000 commented Mar 7, 2021

zhaofengli commented Mar 7, 2021

SuperSandro2000 commented Mar 8, 2021

powerdns-admin: init at 0.2.3 #109841

powerdns-admin: init at 0.2.3 #109841

Conversation

zhaofengli commented Jan 18, 2021

Motivation for this change

Things done

zhaofengli commented Feb 19, 2021

nixos-discourse commented Feb 19, 2021

SuperSandro2000 commented Feb 19, 2021

zhaofengli commented Feb 19, 2021 • edited

SuperSandro2000 commented Feb 19, 2021

SuperSandro2000 commented Feb 19, 2021

zhaofengli commented Feb 19, 2021

zhaofengli commented Feb 22, 2021

SuperSandro2000 commented Feb 22, 2021 • edited

zhaofengli commented Feb 22, 2021

SuperSandro2000 commented Feb 22, 2021

zhaofengli commented Feb 22, 2021

SuperSandro2000 commented Feb 22, 2021

SuperSandro2000 commented Mar 7, 2021

zhaofengli commented Mar 7, 2021

SuperSandro2000 commented Mar 7, 2021

zhaofengli commented Mar 7, 2021

SuperSandro2000 commented Mar 8, 2021

zhaofengli commented Feb 19, 2021 •

edited

SuperSandro2000 commented Feb 22, 2021 •

edited