Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more #8664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means the code depended that the caller did this for us before MakePalette() is executed, which is neither a requirement nor a promise the code makes.
This reduces confusion when reading different drivers.
In testing, I could find no reason why this statement is here. The comment is rather unclear (it states what it does, but not why it would be needed). This line of code was introduced with f4f4044, which gives no further insight on why it would be needed to have it here. As such, let's remove it and see if anyone else reports any problems with it. If so, this commit can be reverted and a more clear comment should be added what this line of code is dealing with (the WHY, not the WHAT).
michicc
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
During final preparations for SDL OpenGL, I found that I jumped the gun on the last cleanup, and already removed some lines that should not have been removed.
Additionally, I had a few more minor cleanups that might as well hit master.
Description
_local_palettewas not reset before making a new palette, potentially not sending the full palette to SDL.Otherwise, a few cleanups (rather minor).
Lastly, removal of a line that is absolutely unclear to me as to why it is there. I cannot find any issue with removing it, so yeah .. there we go.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.