The infinity and NaN length value must be clamped before consumed #27593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2661135
branch
5 times, most recently
from
390648e
to
13ee32b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2661135
branch
from
13ee32b
to
23f256b
Compare
This patch is the second patch of css calc infinity and NaN implementation project and included clamping the infinity and NaN to finite for <Length> and <Length-Percentage>. More details are 4th section in [2]. The Spec: [1] Design docs: [2] Feature Status: [3] Intent to prototype: [4] [1] https://drafts.csswg.org/css-values/#calc-type-checking [2] https://bit.ly/349gXjq [3] https://chromestatus.com/feature/5657825571241984 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/4cT9dMkzVXE/m/aCT8B6PDAwAJ Bug: 1133390 Change-Id: I4e8e488ea9173a82357907ebb5623619c576bd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2661135 Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Seokho Song <0xdevssh@gmail.com> Cr-Commit-Position: refs/heads/master@{#857195}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2661135
branch
from
23f256b
to
8165585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is the second patch of css calc infinity and NaN implementation project and included clamping the infinity and NaN to finite for <Length> and <Length-Percentage>.
More details are 4th section in [2].
The Spec: [1]
Design docs: [2]
Feature Status: [3]
Intent to prototype: [4]
[1] https://drafts.csswg.org/css-values/#calc-type-checking
[2] https://bit.ly/349gXjq
[3] https://chromestatus.com/feature/5657825571241984
[4] https://groups.google.com/a/chromium.org/g/blink-dev/c/4cT9dMkzVXE/m/aCT8B6PDAwAJ
Bug: 1133390
Change-Id: I4e8e488ea9173a82357907ebb5623619c576bd22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2661135
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Cr-Commit-Position: refs/heads/master@{#857195}