Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.NetHTTPSNB: fix stdenv.lib -> lib #109373

Merged
merged 1 commit into from Jan 14, 2021
Merged

perlPackages.NetHTTPSNB: fix stdenv.lib -> lib #109373

merged 1 commit into from Jan 14, 2021

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 14, 2021 •
edited

Motivation for this change

Forgot point out when reviewing #109299

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp merged commit ee5df44 into NixOS:master Jan 14, 2021
@SuperSandro2000
Copy link
Member

Can we please let ofborg finish? Even if this is a no brainer I don't like taking any risk that could break eval anywhere.

@stigtsp
Copy link
Member Author

stigtsp commented Jan 14, 2021

@SuperSandro2000 Sure, good point 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @SuperSandro2000 @alyssais