Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.dhall-yaml: fix dependency test failure, unmark as broken #109380

Merged
merged 3 commits into from Jan 14, 2021

Conversation

mcwitt
Copy link
Contributor

@mcwitt mcwitt commented Jan 14, 2021

Motivation for this change

haskellPackages.dhall-yaml is currently marked broken due to a nondeterministic test failure in the build of a dependency, tasty-expected-failure.

The latter is a known issue and is unresolved upstream (see nomeata/tasty-expected-failure#21).

Things done
  • disabled tests for haskellPackages.tasty-expected-failure
  • haskellPackages.dhall-yaml unmarked broken
  • added completions for dhall-yaml
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants