Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zgrviewer: fix java jre binary path #109381

Merged
merged 1 commit into from Jan 14, 2021
Merged

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Jan 14, 2021

Motivation for this change

I've tried to nix-shell zgrviewer here like I do with a lot of software. I realized that the package was referencing wrongly the java binary.

Things done

Just fixed the java binary location for a jre package (./bin/java)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: GitHub <noreply@github.com>
@SuperSandro2000 SuperSandro2000 merged commit 2416b9d into NixOS:master Jan 14, 2021
@lucasew lucasew deleted the fix/zgrviewer branch January 14, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants