HTML: <object usemap> is removed #27184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
tkent-google and
zqzhang
|
(You could imagine more cases by the way such as what happens when the |
3 tasks
|
Ping @mfreed7 on whether you're interested in this minor |
|
Yes, I'm definitely interested in this cleanup. We have no use counters, but this seems rather safe. In Chromium, this is made interactive here, but I don't see any other behavioral changes to actually do anything other than that. Happy to remove that. |
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13
|
I still don't understand why |
domenic
requested changes
Mar 1, 2021
| @@ -16,6 +16,7 @@ | |||
| <input> | |||
| <label>label</label> | |||
| <object usemap=""></object> | |||
| <object></object> | |||
There was a problem hiding this comment.
I think we could investigate making object interactive, if there's implementer interest, in a separate change. In the meantime, I think you probably want to remove both <object usemap=""> and <object> from here.
There was a problem hiding this comment.
I agree with this comment, and I have a chromium CL in progress with just this change, plus one more suggested by @domenic, to clicking-noninteractive-unlabelable-content.html.
There was a problem hiding this comment.
That would reduce coverage as this is the only test that found out this was a thing to begin with. Not entirely sure how to restructure it though. Or are you suggesting that because Chrome will add back some kind of coverage?
There was a problem hiding this comment.
@mfreed7 how about you import all this and land it as part of the Chromium change?
There was a problem hiding this comment.
Ok, should land soon:
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] #27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634}
pull bot
pushed a commit
to Alan-love/chromium
that referenced
this pull request
Mar 1, 2021
This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] #27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] #27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] #27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#859170}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] #27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#859170}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Mar 3, 2021
See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] web-platform-tests/wpt#27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#859170}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2021
… a=testonly Automatic update from web-platform-tests Remove "usemap" attribute from <object> This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634} -- wpt-commits: 92dd8581875d162e26c2951666e8eeeba828f4d6 wpt-pr: 27830
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 15, 2021
…ct usemap>, a=testonly Automatic update from web-platform-tests More changes related to removal of <object usemap> See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] web-platform-tests/wpt#27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#859170} -- wpt-commits: 58a7619139e80cfad0571957031c9872ea89f05f wpt-pr: 27864
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 15, 2021
… a=testonly Automatic update from web-platform-tests Remove "usemap" attribute from <object> This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreedchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#858634} -- wpt-commits: 92dd8581875d162e26c2951666e8eeeba828f4d6 wpt-pr: 27830 UltraBlame original commit: 84a3cceb690bc31a2578da467f20e17ea702d13a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 15, 2021
…ct usemap>, a=testonly Automatic update from web-platform-tests More changes related to removal of <object usemap> See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] web-platform-tests/wpt#27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreedchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#859170} -- wpt-commits: 58a7619139e80cfad0571957031c9872ea89f05f wpt-pr: 27864 UltraBlame original commit: 04e5678f1cd485d1b59b54ac2a977d2de9c3d064
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 15, 2021
… a=testonly Automatic update from web-platform-tests Remove "usemap" attribute from <object> This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreedchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#858634} -- wpt-commits: 92dd8581875d162e26c2951666e8eeeba828f4d6 wpt-pr: 27830 UltraBlame original commit: 84a3cceb690bc31a2578da467f20e17ea702d13a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 15, 2021
…ct usemap>, a=testonly Automatic update from web-platform-tests More changes related to removal of <object usemap> See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] web-platform-tests/wpt#27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreedchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#859170} -- wpt-commits: 58a7619139e80cfad0571957031c9872ea89f05f wpt-pr: 27864 UltraBlame original commit: 04e5678f1cd485d1b59b54ac2a977d2de9c3d064
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 15, 2021
… a=testonly Automatic update from web-platform-tests Remove "usemap" attribute from <object> This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreedchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#858634} -- wpt-commits: 92dd8581875d162e26c2951666e8eeeba828f4d6 wpt-pr: 27830 UltraBlame original commit: 84a3cceb690bc31a2578da467f20e17ea702d13a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 15, 2021
…ct usemap>, a=testonly Automatic update from web-platform-tests More changes related to removal of <object usemap> See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] web-platform-tests/wpt#27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreedchromium.org> Auto-Submit: Mason Freed <masonfreedchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/master{#859170} -- wpt-commits: 58a7619139e80cfad0571957031c9872ea89f05f wpt-pr: 27864 UltraBlame original commit: 04e5678f1cd485d1b59b54ac2a977d2de9c3d064
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This previously just made the <object> element interactive, but no actual usemap-type behavior was implemented. See [1] and [2] for the effort to remove <object usemap> from the spec. If this CL causes a site bug, please make sure to file a bug on crbug.com/new and cc me. [1] whatwg/html#6283 [2] web-platform-tests/wpt#27184 Fixed: 1182910 Change-Id: I0c7317300b38636cd1144ec776f680a5cd1d6b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725443 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#858634} GitOrigin-RevId: 1d81c3837a4d38837f66fbeb5ace831ddbac3443
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
See [1] and [2] for more context, but this just removes more of the test cases that assume <object usemap> is a thing. [1] https://crrev.com/858634 [2] web-platform-tests/wpt#27184 Bug: 1182910 Change-Id: I6f7bdc6ec33bf9c1cbf3722cd4505a277e1ced56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729397 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#859170} GitOrigin-RevId: 48d9a631ec91394a77edd16f4dab2172a0388972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for whatwg/html#6283.
So the curious case here is
html/semantics/forms/the-label-element/clicking-interactive-content.htmlwhere browsers fail for<object>but not<object usemap>. If I add<span>or<div>I get the same results (only the last of the three tests fails) so I suspect that all browsers do have some logic to consider<object usemap>interactive? Despite Chrome and Safari not supporting<object usemap>otherwise.