Skip to content

redis: make masterAuth option optional #109417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jan 15, 2021
Merged

redis: make masterAuth option optional #109417

1 commit merged into from
Jan 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2021

Motivation for this change

After 9786adf the nixos.tests.gitlab fails to instantiate:

[pbb@regolith:~/proj/nixpkgs]$ nix-build nixos/tests/gitlab.nix
error: A definition for option `services.redis.masterAuth' is not of type `string'. Definition values:
- In `/home/pbb/proj/nixpkgs/nixos/modules/services/databases/redis.nix': null
(use '--show-trace' to show detailed location information)

Since the masterAuth option has a default value of null, its type should probably allow for null as a value.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ghost ghost requested review from dasJ and flokli January 15, 2021 00:45
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 15, 2021
@aanderse
Copy link
Member

A big ❤️ to @dasJ for continuing to slog through #76184.

@ghost ghost merged commit 4171cd5 into NixOS:master Jan 15, 2021
Vskilet pushed a commit to Vskilet/nixpkgs that referenced this pull request May 15, 2021

Verified

This commit was signed with the committer’s verified signature.
delroth Pierre Bourdon
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant